Page MenuHomePhabricator

[Cashtab] Improve notification styles
ClosedPublic

Authored by bytesofman on Jan 7 2025, 03:41.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC6bd50f94a4a8: [Cashtab] Improve notification styles
Summary

We cannot view links with the dark mode notifications on the old settings. Fix the css.

In solving this problem, noticed we really do not need special styled components for links. Get rid of them. Handle all notifications styles globally.

Note this is something we can more easily do now with the latest version of react-toastify. While this is a "bug fix" in some ways... I think it's okay that Cashtab does not test the css colors of all components.

Test Plan

npm test, see screenshots

Current:

image.png (103×351 px, 4 KB)

after this diff:

image.png (103×351 px, 9 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman retitled this revision from [Cashtab] [bugfix] Patch CSS color on link notifications to [Cashtab] Improve notification styles.Jan 7 2025, 03:42
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
bytesofman published this revision for review.Jan 7 2025, 03:48
bytesofman added inline comments.
cashtab/src/components/App/styles.ts
21 ↗(On Diff #52001)

root should go first (googling css best practices)

28 ↗(On Diff #52001)

group toastify stuff together

This revision is now accepted and ready to land.Jan 7 2025, 07:51
This revision was automatically updated to reflect the committed changes.