Page MenuHomePhabricator
Differential D17505

[Cashtab] Patch CI by including mock-chronik-client
ClosedPublic
Actions

Authored by bytesofman on Fri, Jan 10, 04:56.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC4d1dc91c44b4: [Cashtab] Patch CI by including mock-chronik-client
Summary

D17499 broke CI because it introduces a non-test typescript file that uses mock-chronik-client. imo it's important to have this file, which exports functions that will be used to support standardized test frameworks throughout the app. We should not be exporting functions from test files. So the test dir is appropriate for this.

Surprised builds didn't fail before without this dep. But makes sense as mock-chronik-client only used in test files as a dev dep (still just a dev dep), and ts ignores the test files.

Test Plan

docker build -f cashtab.Dockerfile -t cashtab_local .

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Fri, Jan 10, 04:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jan 10, 04:56
Harbormaster completed remote builds in B32027: Diff 52105.Fri, Jan 10, 04:56
bytesofman published this revision for review.Fri, Jan 10, 04:56
bytesofman added a comment.Fri, Jan 10, 05:01

was able to repeat the CI failure locally, failure does not occur with this patch

emack accepted this revision.Fri, Jan 10, 05:08
This revision is now accepted and ready to land.Fri, Jan 10, 05:08
Closed by commit rABC4d1dc91c44b4: [Cashtab] Patch CI by including mock-chronik-client (authored by bytesofman). · Explain WhyFri, Jan 10, 05:08
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC4d1dc91c44b4: [Cashtab] Patch CI by including mock-chronik-client.

Revision Contents
Changeset List

PathSize
6 lines

Diff 52106

View Options

cashtab.Dockerfile

Loading...