Page MenuHomePhabricator
Differential D17575

[Cashtab] No double notifications for SLP partial lists
ClosedPublic
Actions

Authored by bytesofman on Jan 22 2025, 23:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC63dc3deda632: [Cashtab] No double notifications for SLP partial lists
Summary

This was missed in the first pass of removing double notifications. Does not apply to ALP as ALP does not require the "ad prep tx" -- only SLP. NFT listing already has this handled.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 22 2025, 23:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2025, 23:21
Harbormaster completed remote builds in B32183: Diff 52338.Jan 22 2025, 23:26
bytesofman published this revision for review.Jan 22 2025, 23:29
bytesofman added inline comments.
cashtab/src/components/Etokens/Token/index.tsx
1846 ↗(On Diff #52338)

We still have this info in the successful listing notification below

Fabien accepted this revision.Jan 23 2025, 08:16
This revision is now accepted and ready to land.Jan 23 2025, 08:16
Closed by commit rABC63dc3deda632: [Cashtab] No double notifications for SLP partial lists (authored by bytesofman). · Explain WhyJan 23 2025, 08:32
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC63dc3deda632: [Cashtab] No double notifications for SLP partial lists.

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
Etokens/
Token/
6 lines

Diff 52339

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Etokens/Token/index.tsx

Loading...