Differential D17578

[electrum][trezor] Fix homescreen reset
ClosedPublic
Actions

Authored by Fabien on Thu, Jan 23, 13:02.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCbca06065030d: [electrum][trezor] Fix homescreen reset

Summary

The reset sends a null byte as an image, which is invalid.
Trezor has a feature to restore the default homescreen which is sending a empty bytestream, so let's use it.

Test Plan

Reset the screen on all Trezor devices.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, Jan 23, 13:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 23, 13:02

Fabien requested review of this revision.Thu, Jan 23, 13:02

Harbormaster completed remote builds in B32187: Diff 52343.Thu, Jan 23, 13:04

probably broken in some major trezor API change (looks like they passed images as strings before, or maybe it was a python2 thing) https://github.com/spesmilo/electrum/commit/dda9d4b746700bfc095c80d84f1ac5de46c5f2ca

This revision is now accepted and ready to land.Thu, Jan 23, 13:54

Closed by commit rABCbca06065030d: [electrum][trezor] Fix homescreen reset (authored by Fabien). · Explain WhyThu, Jan 23, 14:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbca06065030d: [electrum][trezor] Fix homescreen reset.