Differential D17590
[avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case Authored by roqqit on Fri, Jan 24, 20:07.
Details
Technically the case of avalanche-triggered invalidation is already tested but it makes sense to re-test that behavior here to ensure avalanche invalidation is treated similarly as items being made invalid for other reasons. This patch also improves the test coverage to actually check that the item is no longer being polled, not just that unexpected responses are handled correctly. Depends on D17589 ninja check-avalanche-processor_tests
Diff Detail
Event TimelineComment Actions This is not testing what you think, as it's not testing the node stops polling the invalidated item. It checks that it rejects a unexpected vote, which is the correct behavior but will happen whatever the vote status of the item is. Comment Actions Add comments to make it more clear that the test is checking the item is not being polled for |