Page MenuHomePhabricator
Differential D17607

[avalanche] Poll for stake contenders
Needs RevisionPublic
Actions

Authored by roqqit on Wed, Jan 29, 23:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Poll for stake contenders after they have been promoted to a new chain tip.

Responses to polls will be handled in a follow up diff.

Depends on D17615

Test Plan
ninja check-functional

Diff Detail

Event Timeline

roqqit created this revision.Wed, Jan 29, 23:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 29, 23:51
Harbormaster completed remote builds in B32251: Diff 52437.Thu, Jan 30, 00:00
roqqit updated this revision to Diff 52453.Thu, Jan 30, 17:02

split diff apart

roqqit published this revision for review.Thu, Jan 30, 17:03
roqqit edited the summary of this revision. (Show Details)
roqqit edited the test plan for this revision. (Show Details)
roqqit added a parent revision: D17615: [avalanche] Add stake contender to AnyVoteItem.
Harbormaster completed remote builds in B32264: Diff 52453.Thu, Jan 30, 17:13
Fabien requested changes to this revision.Thu, Jan 30, 20:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/processor.cpp
1069 ↗(On Diff #52453)

This function is no longer doing this but much more. Either change the name or split the function (probably better as it makes unit testing possible).

It also causes the addToReconcile to happen twice per block because this function is called upon updatedBlockTip as well as when staking reward winners are computed.

This revision now requires changes to proceed.Thu, Jan 30, 20:45

Revision Contents
Changeset List

PathSize
src/
avalanche/
24 lines
85 lines
test/
103 lines
test/
functional/
40 lines

Diff 52437

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_contender_voting.py

Loading...