Page MenuHomePhabricator
Differential D17615

[avalanche] Add stake contender to AnyVoteItem
ClosedPublic
Actions

Authored by roqqit on Thu, Jan 30, 16:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC95622f64aac3: [avalanche] Add stake contender to AnyVoteItem
Summary

This adds support in the Processor for stake contenders so we can enable polling and voting.

Test Plan
ninja check-avalanche

Diff Detail

Event Timeline

roqqit created this revision.Thu, Jan 30, 16:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 30, 16:59
roqqit requested review of this revision.Thu, Jan 30, 16:59
roqqit added a child revision: D17607: [avalanche] Poll for stake contenders.Thu, Jan 30, 17:03
Harbormaster completed remote builds in B32263: Diff 52452.Thu, Jan 30, 17:10
Fabien requested changes to this revision.Thu, Jan 30, 18:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/processor.cpp
1440 ↗(On Diff #52452)

That doesn't feel correct to me, you should return == 0. This will be the status of your vote as well

This revision now requires changes to proceed.Thu, Jan 30, 18:59
roqqit updated this revision to Diff 52481.Fri, Jan 31, 22:07

Make local acceptance match what this node would eventually vote

Harbormaster completed remote builds in B32280: Diff 52481.Fri, Jan 31, 22:18
Fabien accepted this revision.Mon, Feb 10, 11:06
This revision is now accepted and ready to land.Mon, Feb 10, 11:06
Closed by commit rABC95622f64aac3: [avalanche] Add stake contender to AnyVoteItem (authored by roqqit). · Explain WhyMon, Feb 10, 17:09
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABC95622f64aac3: [avalanche] Add stake contender to AnyVoteItem.

Revision Contents
Changeset List

PathSize
src/
avalanche/
15 lines
48 lines
test/
122 lines

Diff 52481

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...