Page MenuHomePhabricator
Differential D17642

refactor: move first run detection to client code
ClosedPublic
Actions

Authored by PiRK on Feb 6 2025, 15:07.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABCbfa2db91321b: refactor: move first run detection to client code
Summary

This is a partial backport of core#20773
https://github.com/bitcoin/bitcoin/pull/20773/commits/e2a47ce08528dfb39c0340145c6977f6afd587f6

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 6 2025, 15:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2025, 15:07
PiRK requested review of this revision.Feb 6 2025, 15:07
teamcity edited the summary of this revision. (Show Details)Feb 6 2025, 15:07
PiRK added a child revision: D17643: refactor: Add CWallet:::AttachChain method.Feb 6 2025, 15:08
Harbormaster completed remote builds in B32331: Diff 52550.Feb 6 2025, 15:23
roqqit requested changes to this revision.Feb 7 2025, 00:59
roqqit added a subscriber: roqqit.
roqqit added inline comments.
src/wallet/wallet.cpp
2183 ↗(On Diff #52550)

relatedly, is this supposed to be part of a different changeset?

2188 ↗(On Diff #52550)

was this already backported?

This revision now requires changes to proceed.Feb 7 2025, 00:59
roqqit accepted this revision.Feb 7 2025, 16:44

nvm. compared the wrong lines side-by-side

This revision is now accepted and ready to land.Feb 7 2025, 16:44
Closed by commit rABCbfa2db91321b: refactor: move first run detection to client code (authored by Ivan Metlushko <metlushko@gmail.com>, committed by PiRK). · Explain WhyFeb 8 2025, 10:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbfa2db91321b: refactor: move first run detection to client code.

Revision Contents
Changeset List

PathSize
src/
bench/
3 lines
qt/
test/
4 lines
4 lines
wallet/
test/
3 lines
3 lines
3 lines
2 lines
19 lines
3 lines

Diff 52576

View Options

src/bench/wallet_balance.cpp

Loading...
View Options

src/qt/test/addressbooktests.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/test/coinselector_tests.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/wallettool.cpp

Loading...