p2p_timeouts.py
ClosedPublic
Actions

Authored by PiRK on Sat, Feb 8, 17:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8fc3de71d547: test: fix test failures in test/functional/p2p_timeouts.py

Summary

From the PR discussion:

Fair enough as a temporary workaround.

The source of this bug is that not all time in net is using mocked time, giving those "rounding errors".

The long-term fix should be to use mocked time consistently.

This is a backport of core#23740

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sat, Feb 8, 17:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Feb 8, 17:01

PiRK requested review of this revision.Sat, Feb 8, 17:01

teamcity edited the summary of this revision. (Show Details)Sat, Feb 8, 17:01

Harbormaster completed remote builds in B32356: Diff 52585.Sat, Feb 8, 17:18

Fabien accepted this revision.Sun, Feb 9, 11:20

This revision is now accepted and ready to land.Sun, Feb 9, 11:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8fc3de71d547: test: fix test failures in test/functional/p2p_timeouts.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_timeouts.py

2 lines

Diff 52594

View Options

test/functional/p2p_timeouts.py

test: fix test failures in test/functional/p2p_timeouts.pyClosedPublicActions