Page MenuHomePhabricator
Differential D17667

[ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`
ClosedPublic
Actions

Authored by tobias_ruck on Sat, Feb 15, 19:02.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb9c39dc25864: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`
Summary

Now that the HD wallet is also in ecash-lib, if we can get msg signing, then CashTab could lose bitgo/utxo-lib and bitcoinjs-message as deps.

We use our secp256k1, using Pieter Wuille's blessed code, which is much more rigorously vetted than bitcoinjs-message.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Sat, Feb 15, 19:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Feb 15, 19:02
tobias_ruck requested review of this revision.Sat, Feb 15, 19:02
tobias_ruck edited the summary of this revision. (Show Details)Sat, Feb 15, 19:08
Harbormaster completed remote builds in B32403: Diff 52648.Sat, Feb 15, 19:12
tobias_ruck updated this revision to Diff 52649.Sat, Feb 15, 19:49

bump ecash-lib version

Harbormaster completed remote builds in B32404: Diff 52649.Sat, Feb 15, 19:58
bytesofman accepted this revision.Sat, Feb 15, 21:35

please update the ecash-lib change-log per usual version bump (link to this diff, brief description)

This revision is now accepted and ready to land.Sat, Feb 15, 21:35
Closed by commit rABCb9c39dc25864: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc` (authored by tobias_ruck). · Explain WhySun, Feb 16, 14:13
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCb9c39dc25864: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.

Revision Contents
Changeset List

PathSize
modules/
ecash-lib-wasm/
2 lines
src/
53 lines
ecash-lib/
1 line
4 lines
2 lines
src/
23 lines
22 lines

Diff 52651

View Options

modules/ecash-lib-wasm/Cargo.toml

Loading...
View Options

modules/ecash-lib-wasm/src/ecc.rs

Loading...
View Options

modules/ecash-lib/README.md

Loading...
View Options

modules/ecash-lib/package-lock.json

Loading...
View Options

modules/ecash-lib/package.json

Loading...
View Options

modules/ecash-lib/src/ecc.test.ts

Loading...
View Options

modules/ecash-lib/src/ecc.ts

Loading...