Page MenuHomePhabricator

Re-enable the getavaaddr_interval_test
ClosedPublic

Authored by Fabien on Tue, Feb 18, 09:06.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC206472007eb6: Re-enable the getavaaddr_interval_test
Summary

It appears that the check for relayable peers was done using the wrong availability score. Using the same name in different places for different things is incredibly confusing as demonstrated here. As opposed to the peer availability score which was unused, the node availability score is used under some circumstances like address relaying to filter out the obviously misbehaving nodes. The test was then not checking for the right condition due to using the wrong confusing score. Hopefully this fixes the test flakiness.

Test Plan
for i in {1..100}; do ./test/functional/test_runner.py abc_p2p_getavaaddr || break; done

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Tue, Feb 18, 09:06
PiRK added a subscriber: PiRK.

let's see if it pops up on CI again

This revision is now accepted and ready to land.Tue, Feb 18, 09:41
This revision was automatically updated to reflect the committed changes.