Paths

Table of Contentst

Differential D17676

[chronik] implement server.version electrum method
ClosedPublic
Actions

Authored by PiRK on Wed, Feb 19, 09:33.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC91ef9971ad45: [chronik] implement server.version electrum method

Summary

See https://electrum-cash-protocol.readthedocs.io/en/latest/

We simply return protocol version "1.4" at the moment, which is what fulcrum also report to Electrum ABC's current request.
This is not exact as we only implement a subset of the commands in that version of the spec, but we do follow the rules for the implemented methods (for instance we don't support some 1.5 additional parameters to blockchain.scripthash.history)

Test Plan

ninja check-functional

Compare results and errors to what a Fulcrum instance returns for similar requests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Feb 19, 09:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 19, 09:33

PiRK requested review of this revision.Wed, Feb 19, 09:33

PiRK edited the summary of this revision. (Show Details)Wed, Feb 19, 09:33

PiRK added inline comments.

chronik/chronik-http/Cargo.toml
81 ↗	(On Diff #52671)	Already used in chronik-plugins, so this does not technically add a dependency

remove done TODO

Fabien added a subscriber: Fabien.Wed, Feb 19, 09:48

Fabien added inline comments.

chronik/chronik-http/src/electrum.rs
357 ↗	(On Diff #52671)	That's done ?

I reviewed the previous revision, the TODO is indeed done

This revision is now accepted and ready to land.Wed, Feb 19, 09:49

Harbormaster completed remote builds in B32415: Diff 52671.Wed, Feb 19, 09:55

Harbormaster completed remote builds in B32416: Diff 52672.Wed, Feb 19, 10:09

Closed by commit rABC91ef9971ad45: [chronik] implement server.version electrum method (authored by PiRK). · Explain WhyThu, Feb 20, 07:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC91ef9971ad45: [chronik] implement server.version electrum method.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

3 lines

src/

58 lines

test/

functional/

chronik_electrum_basic.py

55 lines

Diff 52685

Cargo.lock

Loading...

chronik/chronik-http/Cargo.toml

Loading...

chronik/chronik-http/src/electrum.rs

Loading...

test/functional/chronik_electrum_basic.py

Loading...