Paths

Table of Contentst

Differential D17690

test: remove unnecessary block rehashing prior to solving
ClosedPublic
Actions

Authored by PiRK on Mon, Feb 24, 13:21.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC33c0dc6359a1: test: remove unnecessary block rehashing prior to solving

Summary

Solving a block involves continously rehashing it, i.e. any extra
calls to rehash it before are not necessary and can be dropped.

This is a backport of core#23498

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Feb 24, 13:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Feb 24, 13:21

PiRK requested review of this revision.Mon, Feb 24, 13:21

teamcity edited the summary of this revision. (Show Details)Mon, Feb 24, 13:21

Harbormaster completed remote builds in B32462: Diff 52730.Mon, Feb 24, 13:30

roqqit accepted this revision.Mon, Feb 24, 16:42

This revision is now accepted and ready to land.Mon, Feb 24, 16:42

Closed by commit rABC33c0dc6359a1: test: remove unnecessary block rehashing prior to solving (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyMon, Feb 24, 17:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC33c0dc6359a1: test: remove unnecessary block rehashing prior to solving.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_assumevalid.py

1 line

feature_bip68_sequence.py

2 lines

feature_block.py

1 line

feature_csv_activation.py

1 line

feature_dersig.py

3 lines

p2p_invalid_block.py

4 lines

wallet_resendwallettransactions.py

1 line

Diff 52734

View Options

test/functional/feature_assumevalid.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/wallet_resendwallettransactions.py

test: remove unnecessary block rehashing prior to solvingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52734

test/functional/feature_assumevalid.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_csv_activation.py

test/functional/feature_dersig.py

test/functional/p2p_invalid_block.py

test/functional/wallet_resendwallettransactions.py

test: remove unnecessary block rehashing prior to solving
ClosedPublic
Actions

Revision Contents
Changeset List