index: Don't commit a best block before indexing it during sync
ClosedPublic
Actions

Authored by PiRK on Wed, Feb 26, 15:30.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABCef3b321b2815: index: Don't commit a best block before indexing it during sync

Summary

Committing a block prior to indexing would leave the index database
in an inconsistent state until it is indexed, which could corrupt the
index in case of a unclean shutdown. Thus commit its predecessor.

Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
This is a backport of core#25074

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Feb 26, 15:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 26, 15:30

PiRK requested review of this revision.Wed, Feb 26, 15:30

teamcity edited the summary of this revision. (Show Details)Wed, Feb 26, 15:30

PiRK added a child revision: D17703: doc: BaseIndex sync behavior with empty datadir.Wed, Feb 26, 15:32

Harbormaster completed remote builds in B32496: Diff 52777.Wed, Feb 26, 15:40

roqqit accepted this revision.Wed, Feb 26, 16:39

This revision is now accepted and ready to land.Wed, Feb 26, 16:39

Closed by commit rABCef3b321b2815: index: Don't commit a best block before indexing it during sync (authored by Martin Zumsande <mzumsande@gmail.com>, committed by PiRK). · Explain WhyWed, Feb 26, 16:54

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCef3b321b2815: index: Don't commit a best block before indexing it during sync.

Revision Contents
Changeset List

Path

Size

src/

index/

base.cpp

2 lines

Diff 52784

View Options

index: Don't commit a best block before indexing it during syncClosedPublicActions