Page MenuHomePhabricator

[avalanche] Fix a race in contenders voting test
ClosedPublic

Authored by roqqit on Fri, Feb 28, 21:15.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCd029363ecc33: [avalanche] Fix a race in contenders voting test
Summary

There is a race where the chain tip may have started polling but contenders have not yet. It is more robust to answer polls until we see local_winner_cid (and the chain tip will have started polling before that, but we ultimately don't care about this).

Test Plan

Run a few times:

for I in {0..10}; do ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting || break ; done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sc-fix-polled-contenders
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32553
Build 64594: Build Diffbuild-diff · build-clang-tidy · build-clang · build-debug · build-without-wallet
Build 64593: arc lint + arc unit