Rename various variable so they do not shadow
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 13:23.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6ad95c3bab28: Rename various variable so they do not shadow
rABC6ad95c3bab28: Rename various variable so they do not shadow

Summary

As per title, this also uncovered a problem in the RPC code when dumping help for each method.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 12 2018, 13:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 13:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3280: Diff 4893.Sep 12 2018, 13:58

schancel retitled this revision from Rename various variable so they do not shaddow to Rename various variable so they do not shadow.Sep 15 2018, 15:11

schancel edited the summary of this revision. (Show Details)

schancel accepted this revision.Sep 15 2018, 15:14

schancel added a subscriber: schancel.

schancel added inline comments.

src/rpc/server.cpp
226 ↗	(On Diff #4893)	Is this the problem that had been discovered?
src/script/sigcache.h
49 ↗	(On Diff #4893)	What are these things shadowing?
src/script/sign.h
58 ↗	(On Diff #4893)	Worst variable name ever.