Page MenuHomePhabricator

[Cashtab] Drop test causing problems in CI
ClosedPublic

Authored by bytesofman on Thu, Mar 13, 21:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcf49ef6cf520: [Cashtab] Drop test causing problems in CI
Summary

Not precisely sure what causes this to fail in CI but it is likely related to the special character used in the formatting. We do not really need this test to confirm expected behavior in Cashtab. So, drop it.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

remove other test that appears to fail for the same reason

This revision is now accepted and ready to land.Thu, Mar 13, 21:08

Failed tests logs:

====== CashTab Unit Tests: Correctly executes formatting functions We can format an XEC balance toFormattedXec: Balance less than 1 thousand XEC, but arabic ======
Error: expect(received).toBe(expected) // Object.is equality

Expected: "٩٩٩٫٩٩"
Received: "999.99"
    at Object.toBe (/work/cashtab/src/formatting/__tests__/index.test.js:135:62)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)

Each failure log is accessible here:
CashTab Unit Tests: Correctly executes formatting functions We can format an XEC balance toFormattedXec: Balance less than 1 thousand XEC, but arabic