Differential D17813

[avalanche] Cleanup circular dependency between peer manager and contender cache
ClosedPublic
Actions

Authored by roqqit on Mon, Mar 17, 19:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcf38f5e5d94a: [avalanche] Cleanup circular dependency between peer manager and contender cache

Summary

Now that peerManager owns the contender cache, it also makes sense for it to own the contender promotion logic as it pertains to proof status.

The unit test changes ensure we do not regress on the case where dangling remote proofs can still be accepted stake contenders.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-cleanup-circdep

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32744
Build 64976: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-diff · build-clang · build-clang-tidy
Build 64975: arc lint + arc unit

Event Timeline

roqqit created this revision.Mon, Mar 17, 19:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 17, 19:44

roqqit requested review of this revision.Mon, Mar 17, 19:44

Harbormaster completed remote builds in B32744: Diff 53141.Mon, Mar 17, 20:01

Fabien accepted this revision.Mon, Mar 17, 21:39

This revision is now accepted and ready to land.Mon, Mar 17, 21:39

Closed by commit rABCcf38f5e5d94a: [avalanche] Cleanup circular dependency between peer manager and contender cache (authored by roqqit). · Explain WhyMon, Mar 17, 22:10

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCcf38f5e5d94a: [avalanche] Cleanup circular dependency between peer manager and contender cache.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

5 lines

stakecontendercache.h

4 lines

stakecontendercache.cpp

9 lines

test/

processor_tests.cpp

60 lines

stakecontendercache_tests.cpp

59 lines

test/

lint/

lint-circular-dependencies.sh

1 line

Diff 53141

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/stakecontendercache.h

View Options

src/avalanche/stakecontendercache.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/avalanche/test/stakecontendercache_tests.cpp

View Options

test/lint/lint-circular-dependencies.sh

[avalanche] Cleanup circular dependency between peer manager and contender cacheClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53141

src/avalanche/peermanager.cpp

src/avalanche/stakecontendercache.h

src/avalanche/stakecontendercache.cpp

src/avalanche/test/processor_tests.cpp

src/avalanche/test/stakecontendercache_tests.cpp

test/lint/lint-circular-dependencies.sh

[avalanche] Cleanup circular dependency between peer manager and contender cache
ClosedPublic
Actions

Revision Contents
Changeset List