Differential D17834

[avalanche] Refactor helpers to build avaproofs messages
ClosedPublic
Actions

Authored by roqqit on Wed, Mar 19, 22:48.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC892275701a2b: [avalanche] Refactor helpers to build avaproofs messages

Summary

This refactor makes build_msg_avaproofs more reusable in other tests which
will be leveraged in a future diff. It also cleans up unnecessary and complex
code in abc_p2p_avalanche_remote_proofs which we should discourage copying.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

compactproofs-cleanuptests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32778
Build 65044: Build Diff	build-diff · build-clang-tidy · build-debug · build-clang · build-without-wallet
Build 65043: arc lint + arc unit

Event Timeline

roqqit created this revision.Wed, Mar 19, 22:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 19, 22:48

roqqit requested review of this revision.Wed, Mar 19, 22:48

Harbormaster completed remote builds in B32778: Diff 53192.Wed, Mar 19, 22:57

PiRK accepted this revision.Thu, Mar 20, 07:37

This revision is now accepted and ready to land.Thu, Mar 20, 07:37

Closed by commit rABC892275701a2b: [avalanche] Refactor helpers to build avaproofs messages (authored by roqqit). · Explain WhyThu, Mar 20, 17:06

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC892275701a2b: [avalanche] Refactor helpers to build avaproofs messages.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_remote_proofs.py

34 lines

abc_p2p_compactproofs.py

20 lines

test_framework/

20 lines

Diff 53192

test/functional/abc_p2p_avalanche_remote_proofs.py

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...

test/functional/test_framework/avatools.py

Loading...