Paths

Table of Contentst

[chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client
ClosedPublic
Actions

Authored by hazzarust on Mon, Mar 24, 17:36.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC396a501ae4d5: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client

Summary

For future integration tests, the functions need to toggle skip_token_checks: bool.

Test Plan

Please set BUILD_DIR env to export BUILD_DIR="/path/to/build_dir
UNIX: ./contrib/teamcity/build-configurations.py build-bitcoinsuite-chronik-client

Diff Detail

Repository

rABC Bitcoin ABC

Branch

broadcasttx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32821
Build 65130: Build Diff	build-bitcoinsuite-chronik-client
Build 65129: arc lint + arc unit

Event Timeline

hazzarust created this revision.Mon, Mar 24, 17:36

Owners added a reviewer: Restricted Owners Package.Mon, Mar 24, 17:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 24, 17:36

hazzarust requested review of this revision.Mon, Mar 24, 17:36

hazzarust added a child revision: D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.Mon, Mar 24, 17:36

hazzarust edited the summary of this revision. (Show Details)

hazzarust retitled this revision from [chronik] Ammend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client to [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.Mon, Mar 24, 17:39

Fabien requested changes to this revision.Mon, Mar 24, 17:43

Fabien added a subscriber: Fabien.

Fabien added inline comments.

modules/bitcoinsuite-chronik-client/src/lib.rs
108 ↗	(On Diff #53248)	Why did you move this code ?

This revision now requires changes to proceed.Mon, Mar 24, 17:43

Harbormaster completed remote builds in B32815: Diff 53248.Mon, Mar 24, 17:48

change ordering

Harbormaster completed remote builds in B32821: Diff 53258.Tue, Mar 25, 13:17

Fabien accepted this revision.Tue, Mar 25, 15:58

This revision is now accepted and ready to land.Tue, Mar 25, 15:58

Closed by commit rABC396a501ae4d5: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client (authored by hazzarust). · Explain WhyTue, Mar 25, 19:02

This revision was automatically updated to reflect the committed changes.

hazzarust added a commit: rABC396a501ae4d5: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.

Revision Contents
Changeset List

Path

Size

modules/

bitcoinsuite-chronik-client/

src/

lib.rs

6 lines

tests/

test_chronik_client.rs

4 lines

Diff 53258

View Options

modules/bitcoinsuite-chronik-client/src/lib.rs