Differential D17861

[avalanche] Make sure to only promote contenders once for each proofid
ClosedPublic
Actions

Authored by roqqit on Wed, Mar 26, 23:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCaff18f3253ee: [avalanche] Make sure to only promote contenders once for each proofid

Summary

Looping over the contenders container while inserting causes the loop to go over the newly inserted items which is not intended. For better or worse, double inserting a contender has no change in behavior, so this diff does not either.

Depends on D17860

Test Plan

./test/functional/test_runner.py --nocleanup abc_p2p_avalanche_contender_voting

Verify in the log that when contenders are promoted, "new id <contenderid>" never appears duplicated.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Wed, Mar 26, 23:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 26, 23:12

roqqit requested review of this revision.Wed, Mar 26, 23:12

Harbormaster completed remote builds in B32831: Diff 53274.Wed, Mar 26, 23:24

Fabien requested changes to this revision.Thu, Mar 27, 09:36

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/stakecontendercache.cpp
75 ↗	(On Diff #53274)	You don't need the set. The new contender id will be the same if you have a proofid promoted several times (because they are present for several past blocks) and the insert below will just skip them safely.