Page MenuHomePhabricator
Differential D1793

[qa] Test for duplicate inputs within a transaction
ClosedPublic
Actions

Authored by jtoomim on Sep 18 2018, 17:56.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3710f45a9aa6: [qa] Test for duplicate inputs within a transaction
rABC3710f45a9aa6: [qa] Test for duplicate inputs within a transaction
Summary

Co-authored-by: Suhas Daftuar <sdaftuar@gmail.com>

https://github.com/bitcoinxt/bitcoinxt/pull/486
https://github.com/bitcoin/bitcoin/pull/14247

Test Plan

test_runner.py invalidblockrequest.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtoomim created this revision.Sep 18 2018, 17:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2018, 17:56
teamcity added a subscriber: teamcity.Sep 18 2018, 17:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Sep 18 2018, 18:14
jasonbcox added a subscriber: jasonbcox.

Include this in the summary to give dagur proper credit:
Co-authored-by: Dagur Valberg Johannsson <dagurval@pvv.ntnu.no>

Also update the test plan to include testing this file specifically, as make check will not run it:
test_runner.py invalidblockrequest.py

This revision now requires changes to proceed.Sep 18 2018, 18:14
jasonbcox added a comment.Sep 18 2018, 18:15

You may also include this in the summary: https://github.com/bitcoinxt/bitcoinxt/pull/486

jtoomim edited the summary of this revision. (Show Details)Sep 18 2018, 18:21
jtoomim edited the test plan for this revision. (Show Details)
jtoomim edited the summary of this revision. (Show Details)
jasonbcox accepted this revision.Sep 18 2018, 18:25
This revision is now accepted and ready to land.Sep 18 2018, 18:25
teamcity added a comment.Sep 18 2018, 18:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3326: Diff 4967!Sep 18 2018, 18:33
jtoomim updated this revision to Diff 4968.Sep 18 2018, 19:36
jtoomim edited the summary of this revision. (Show Details)

Rebase on master

teamcity added a comment.Sep 18 2018, 19:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 18 2018, 20:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3327: Diff 4968.Sep 18 2018, 20:14
Closed by commit rABC3710f45a9aa6: [qa] Test for duplicate inputs within a transaction (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by jtoomim). · Explain WhySep 18 2018, 20:23
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
10 lines

Diff 4969

View Options

test/functional/invalidblockrequest.py

Loading...