Page MenuHomePhabricator

jtoomim (Jonathan Toomim)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2018, 17:56 (49 w, 23 h)

Recent Activity

May 16 2019

jtoomim updated the diff for D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Newline after function definition

May 16 2019, 05:54
jtoomim added inline comments to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.
May 16 2019, 05:47

May 11 2019

jtoomim updated the diff for D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Adding tests to test/functional/wallet_basic.py for insufficient balance

May 11 2019, 08:27
jtoomim added a comment to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Note: FlameGraph performance testing shows that this code changes CPU usage by GetBalance at 7.88% of total before this change, and CheckBalance at 0.10% after this change. (Only 45% of CPU was used by bitcoind/bitcoin-cli in my test; most of the rest is idle.) This is for a wallet with many thousands of UTXOs.

May 11 2019, 06:55
Herald added a reviewer for D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress: deadalnix.
May 11 2019, 06:41

Jan 25 2019

jtoomim added a comment to D2405: Adds a functional test for CPFP with depth 1..

@ealmansi The reason you need the extra test node is because there's a third thing you need to check:

Jan 25 2019, 03:17

Jan 20 2019

jtoomim updated the task description for T525: $1000-$2000 bounty: Improve getblocktemplate/mempool performance with long transaction chains.
Jan 20 2019, 04:33 · Bounty
jtoomim created T525: $1000-$2000 bounty: Improve getblocktemplate/mempool performance with long transaction chains.
Jan 20 2019, 04:29 · Bounty

Nov 24 2018

jtoomim added a comment to D2125: Delay finalization until 2 hours after IBD is recorded as finished.

So the attack here is this:

Nov 24 2018, 03:00

Sep 27 2018

jtoomim committed rSTAGING3710f45a9aa6: [qa] Test for duplicate inputs within a transaction (authored by Suhas Daftuar <sdaftuar@gmail.com>).
[qa] Test for duplicate inputs within a transaction
Sep 27 2018, 19:04
jtoomim committed rSTAGING59d52b9da186: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init) (authored by jtoomim).
Fix bench/bench_bitcoin (Select REGTEST Params before wallet init)
Sep 27 2018, 19:04
jtoomim committed rSTAGING4ae37d54ba3d: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This… (authored by jtoomim).
Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This…
Sep 27 2018, 19:03

Sep 18 2018

jtoomim committed rABC3710f45a9aa6: [qa] Test for duplicate inputs within a transaction (authored by Suhas Daftuar <sdaftuar@gmail.com>).
[qa] Test for duplicate inputs within a transaction
Sep 18 2018, 20:23
jtoomim closed D1793: [qa] Test for duplicate inputs within a transaction.
Sep 18 2018, 20:23
jtoomim updated the diff for D1793: [qa] Test for duplicate inputs within a transaction.

Rebase on master

Sep 18 2018, 19:36
jtoomim updated the summary of D1793: [qa] Test for duplicate inputs within a transaction.
Sep 18 2018, 18:22
jtoomim updated the test plan for D1793: [qa] Test for duplicate inputs within a transaction.
Sep 18 2018, 18:21
Herald added a reviewer for D1793: [qa] Test for duplicate inputs within a transaction: Restricted Project.
Sep 18 2018, 17:56

Sep 17 2018

jtoomim committed rABC59d52b9da186: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init) (authored by jtoomim).
Fix bench/bench_bitcoin (Select REGTEST Params before wallet init)
Sep 17 2018, 07:59
jtoomim closed D1787: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init).
Sep 17 2018, 07:59
Herald added a reviewer for D1787: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init): Restricted Project.
Sep 17 2018, 07:57

Sep 15 2018

jtoomim committed rABC4ae37d54ba3d: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This… (authored by jtoomim).
Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This…
Sep 15 2018, 20:26
jtoomim closed D1784: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of....
Sep 15 2018, 20:26
jtoomim updated the diff for D1784: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of....

Change INV_BROADCAST... to use config.GetMaxBlockSize() (2nd arc attempt)

Sep 15 2018, 20:07
jtoomim updated the diff for D1784: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of....

Switch INV_BROADCAST... to using config.GetMaxBlockSize()

Sep 15 2018, 20:05

Sep 13 2018

jtoomim abandoned D1782: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of....

Abandoning this diff in favor of https://reviews.bitcoinabc.org/D1784

Sep 13 2018, 22:45
Herald added a reviewer for D1784: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of...: Restricted Project.
Sep 13 2018, 19:56
jtoomim abandoned D1783: Switch INVENTORY_BROADCAST_MAX to INVENTORY_BROADCAST_MAX_PER_MB.

arc diff didn't produce the expected results; abandoning and trying again.

Sep 13 2018, 19:52
jtoomim created D1783: Switch INVENTORY_BROADCAST_MAX to INVENTORY_BROADCAST_MAX_PER_MB.
Sep 13 2018, 19:38
Herald added a reviewer for D1782: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of...: Restricted Project.
Sep 13 2018, 01:12