Page MenuHomePhabricator
Differential D1784

Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of...
ClosedPublic
Actions

Authored by jtoomim on Sep 13 2018, 19:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4ae37d54ba3d: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This…
rABC4ae37d54ba3d: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This…
Summary

...upstream bandwith for INVs, plus an unspecified and unpredictable amount of bandwidth for the transactions themselves.

Test Plan

test_bitcoin works. Running with debug=net appears to work as expected. I have not tested this with higher tx throughput than is currently available on mainnet, as no such testnet is currently available.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtoomim created this revision.Sep 13 2018, 19:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2018, 19:56
teamcity added a subscriber: teamcity.Sep 13 2018, 19:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 13 2018, 19:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3296: Diff 4909!Sep 13 2018, 19:59
teamcity added a comment.Sep 13 2018, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 13 2018, 22:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix requested changes to this revision.Sep 14 2018, 12:37
deadalnix added inline comments.
src/net_processing.cpp
25 ↗(On Diff #4909)

Remove.

3506 ↗(On Diff #4909)

Get the max block size from the config.

3599 ↗(On Diff #4909)

dito

This revision now requires changes to proceed.Sep 14 2018, 12:37
jtoomim updated this revision to Diff 4937.Sep 15 2018, 20:05

Switch INV_BROADCAST... to using config.GetMaxBlockSize()

Harbormaster completed remote builds in B3311: Diff 4937.Sep 15 2018, 20:05
deadalnix accepted this revision.Sep 15 2018, 20:06

likestamp

This revision is now accepted and ready to land.Sep 15 2018, 20:06
jtoomim updated this revision to Diff 4939.Sep 15 2018, 20:07

Change INV_BROADCAST... to use config.GetMaxBlockSize() (2nd arc attempt)

teamcity added a comment.Sep 15 2018, 20:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3312: Diff 4939!Sep 15 2018, 20:08
teamcity added a comment.Sep 15 2018, 20:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix accepted this revision.Sep 15 2018, 20:12
Closed by commit rABC4ae37d54ba3d: Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This… (authored by jtoomim). · Explain WhySep 15 2018, 20:26
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
7 lines
2 lines

Diff 4940

View Options

src/net_processing.cpp

Loading...
View Options

src/validation.h

Loading...