Page MenuHomePhabricator

Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of...
ClosedPublic

Authored by jtoomim on Sep 13 2018, 19:56.

Details

Summary

...upstream bandwith for INVs, plus an unspecified and unpredictable amount of bandwidth for the transactions themselves.

Test Plan

test_bitcoin works. Running with debug=net appears to work as expected. I have not tested this with higher tx throughput than is currently available on mainnet, as no such testnet is currently available.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
inv-broadcast-per-mb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3296
Build 4676: Bitcoin ABC Buildbot (legacy)
Build 4675: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Sep 14 2018, 12:37
deadalnix added inline comments.
src/net_processing.cpp
25

Remove.

3506

Get the max block size from the config.

3599

dito

This revision now requires changes to proceed.Sep 14 2018, 12:37

Switch INV_BROADCAST... to using config.GetMaxBlockSize()

This revision is now accepted and ready to land.Sep 15 2018, 20:06

Change INV_BROADCAST... to use config.GetMaxBlockSize() (2nd arc attempt)

This revision was automatically updated to reflect the committed changes.