HomePhabricator

miner: Remove use of CPFP in CreateNewBlock
Audit Required3899ab994eb2

Tags
  • Restricted Project
Subscribers
None
Tokens
"Pterodactyl" token, awarded by Unknown Object (User).

Description

miner: Remove use of CPFP in CreateNewBlock

Summary:

This removes the use of CPFP during block generation. Instead, transactions
are evaluated for block inclusion on individual bases by modified fee rate.

Port of bchn#1078.

The code has been largely massaged, with 2 main differences:

  • We use CTxMempoolEntry at some places instead of the iterator, because this is what our API returns/expects.
  • The 1-time lambdas are removed to make the code easier to read (with a single exception).

There will be more cleaning up in a follow up.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Subscribers: sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D13116

Details

Auditors
Unknown Object (User)
Provenance
jtoomimAuthored on Feb 17 2021, 10:45
FabienCommitted on Feb 14 2023, 09:02
FabienPushed on Feb 14 2023, 09:02
Reviewer
Restricted Project
Differential Revision
D13116: miner: Remove use of CPFP in CreateNewBlock
Parents
rABC1203360d8a45: Call CHECK_NONFATAL only once where needed
Branches
Unknown
Tags
Unknown

Event Timeline

Unknown Object (User) awarded a token.Feb 15 2023, 04:29
Unknown Object (User) added a subscriber: Unknown Object (User).
Unknown Object (User) added an auditor: Unknown Object (User).Feb 15 2023, 05:10
Unknown Object (User) added a project: Restricted Project.
This commit now requires audit.Feb 15 2023, 05:10