s of...
AbandonedPublic
Actions

Authored by jtoomim on Sep 13 2018, 01:12.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

...upstream bandwith for INVs, plus an unspecified and unpredictable amount of bandwidth for the transactions themselves.

Test Plan

test_bitcoin works. Running with debug=net appears to work as expected. I have not tested this with higher tx throughput than is currently available on mainnet, as no such testnet is currently available.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

inv-broadcast-interval

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3293
Build 4672: Bitcoin ABC Buildbot (legacy)
Build 4671: arc lint + arc unit

Event Timeline

jtoomim created this revision.Sep 13 2018, 01:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2018, 01:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3293: Diff 4906!Sep 13 2018, 01:15

Could you change the constant to INVENTORY_BROADCAST_MAX_PER_MB and then multiply by the value in the config at use point ?

This revision now requires changes to proceed.Sep 13 2018, 11:19

Abandoning this diff in favor of https://reviews.bitcoinabc.org/D1784

Revision Contents
Changeset List

Path

Size

src/

validation.h

3 lines

Diff 4906

View Options

Increase INVENTORY_BROADCAST_MAX to 1170 (based on 32MB max message size). This allows ABC to advertise transactions at up to 234 tx/sec. For a node with 50 peers and ~50 bytes per tx (including INV overhead), this would consume about 585 kB/s of...AbandonedPublicActions