Differential D17971

[avalanche] Fix a lock order inversion
ClosedPublic
Actions

Authored by Fabien on Tue, Apr 22, 21:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0971f430079f: [avalanche] Fix a lock order inversion

Summary

Introduced in D17832, we are calling addToReconcile() which in turns calls IsWorthPolling() with cs_main hold, which is not possible.

Test Plan

Run the TSAN build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Apr 22, 21:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 22, 21:56

Fabien requested review of this revision.Tue, Apr 22, 21:56

@bot build-tsan

teamcity awarded a token.Tue, Apr 22, 21:56

Harbormaster completed remote builds in B33052: Diff 53612.Tue, Apr 22, 22:16

PiRK accepted this revision.Wed, Apr 23, 07:37

This revision is now accepted and ready to land.Wed, Apr 23, 07:37

Closed by commit rABC0971f430079f: [avalanche] Fix a lock order inversion (authored by Fabien). · Explain WhyWed, Apr 23, 07:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0971f430079f: [avalanche] Fix a lock order inversion.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

29 lines

Diff 53621

View Options

[avalanche] Fix a lock order inversionClosedPublicActions