Page MenuHomePhabricator

Assert the exact list of contenders to be polled in tests
DraftPublic

Authored by Fabien on Wed, Apr 30, 16:47.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This is more accurate than checking for the number of polls. This also makes the test capable of handling slowly connecting peers, which could cause a contender poll to finalize before the other contenders are registered (so the poll count will be lower than the expected 12). By checking the set over the whole quorum we remove this constraint entirely.

This implies to properly compare the proof rankings also, so we fix the rank computation by using the exact score and no longer assume 5000.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_contenders_3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33185
Build 65853: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 65852: arc lint + arc unit