Page MenuHomePhabricator
Differential D18037

[test] Don't assume the proof score in abc_p2p_avalanche_contender_voting
Needs ReviewPublic
Actions

Authored by Fabien on Thu, May 1, 11:21.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

The proof score is assumed to be 5000, aka 50M XEC of staked amount. This is only true for as long as no staking reward output is added to the coinbase. This diff removes this assumption for the get_all_contender_ids() function and prevent using the other methods that rely on this fact after it turns out wrong.

This is a step towards fixing the test flakiness.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_proof_ranking
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33187
Build 65857: Build Diffbuild-clang-tidy · build-debug · build-clang · build-diff · build-without-wallet
Build 65856: arc lint + arc unit

Revision Contents
Changeset List

PathSize
test/
functional/
31 lines
test_framework/
3 lines

Diff 53807

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...