Page MenuHomePhabricator
Differential D18057

[ecash-lib] Add parseEmppScript method
ClosedPublic
Actions

Authored by bytesofman on Tue, May 6, 21:33.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABCab3fcc0da679: [ecash-lib] Add parseEmppScript method
Summary

We have a number of methods for parsing individual pushes from an EMPP OP_RETURN, but we are missing a method to take the EMPP script and get the individual pushes.

Add it here.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Tue, May 6, 21:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 6, 21:33
bytesofman updated this revision to Diff 53880.Tue, May 6, 21:35

update diff info in readme

Harbormaster completed remote builds in B33229: Diff 53879.Tue, May 6, 21:42
Harbormaster completed remote builds in B33230: Diff 53880.Tue, May 6, 21:45
bytesofman published this revision for review.Tue, May 6, 21:49
tobias_ruck requested changes to this revision.Tue, May 6, 21:51
tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
modules/ecash-lib/src/token/empp.ts
31 ↗(On Diff #53880)

add a nice doc comment

This revision now requires changes to proceed.Tue, May 6, 21:51
bytesofman updated this revision to Diff 53881.Tue, May 6, 22:06

function doc

Harbormaster completed remote builds in B33231: Diff 53881.Tue, May 6, 22:16
tobias_ruck accepted this revision.Wed, May 7, 09:18
This revision is now accepted and ready to land.Wed, May 7, 09:18
Closed by commit rABCab3fcc0da679: [ecash-lib] Add parseEmppScript method (authored by bytesofman). · Explain WhyWed, May 7, 11:23
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCab3fcc0da679: [ecash-lib] Add parseEmppScript method.

Revision Contents
Changeset List

PathSize
modules/
ecash-lib/
1 line
4 lines
2 lines
src/
token/
74 lines
43 lines

Diff 53883

View Options

modules/ecash-lib/README.md

Loading...
View Options

modules/ecash-lib/package-lock.json

Loading...
View Options

modules/ecash-lib/package.json

Loading...
View Options

modules/ecash-lib/src/token/empp.test.ts

Loading...
View Options

modules/ecash-lib/src/token/empp.ts

Loading...