clang-tidy: Add more performance checks
Needs ReviewPublic
Actions

Authored by PiRK on Sat, May 10, 15:31.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

clang-tidy: Add performance-faster-string-find check

https://clang.llvm.org/extra/clang-tidy/checks/performance/faster-string-find.html

https://github.com/bitcoin/bitcoin/pull/26642/commits/516b75f66ec3ba7495fc028c750937bd66cc9bba

clang-tidy: Add performance-type-promotion-in-math-fn check

https://clang.llvm.org/extra/clang-tidy/checks/performance/type-promotion-in-math-fn.html

https://github.com/bitcoin/bitcoin/pull/26642/commits/24004372302adfc0e7cb36f8db6830694bf050e9

clang-tidy: Exclude performance-* checks rather including themi

https://github.com/bitcoin/bitcoin/pull/26642/commits/03ec5b6f9ca3af28c9ce25cf2393e28ae852d808

Also address a performance-inefficient-algorithm warning in minerfund.cpp:
https://clang.llvm.org/extra/clang-tidy/checks/performance/inefficient-algorithm.html

This concludes backport of core#26642
Depends on D18072

Test Plan

ninja all check-all bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr26758

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33272
Build 66026: Build Diff	build-debug · build-diff · build-clang · lint-circular-dependencies · build-without-wallet · build-clang-tidy
Build 66025: arc lint + arc unit

Event Timeline

PiRK created this revision.Sat, May 10, 15:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, May 10, 15:31

PiRK requested review of this revision.Sat, May 10, 15:31

teamcity edited the summary of this revision. (Show Details)Sat, May 10, 15:31

Harbormaster completed remote builds in B33271: Diff 53937.Sat, May 10, 15:36

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[396/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[397/581] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[398/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[399/581] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[400/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[401/581] Linking CXX executable src/bitcoin-cli
[402/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[403/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[404/581] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[405/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[406/581] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[407/581] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[408/581] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[409/581] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[410/581] Linking CXX executable src/bitcoin-tx
[411/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[412/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[413/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[414/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[415/581] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[416/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[418/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[419/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[420/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[421/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[422/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[423/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[424/581] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[425/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[426/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[427/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[428/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[429/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[430/581] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[431/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[432/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[433/581] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[434/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[435/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[436/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[437/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[438/581] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[439/581] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[440/581] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[441/581] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[442/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[443/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[444/581] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[445/581] Linking CXX executable src/iguana/iguana
[446/581] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[447/581] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[448/581] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[449/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[450/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[451/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[452/581] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[453/581] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

15:34:35 
  /work/src/minerfund.cpp:80:13: error: this STL algorithm call should be replaced with a container method [performance-inefficient-algorithm,-warnings-as-errors]

15:34:35 
          if (std::find(whitelist.begin(), whitelist.end(), address) !=

15:34:35 
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

15:34:35 
              whitelist.find(address)