Differential D18082

Fix a use after free error
ClosedPublic
Actions

Authored by Fabien on Mon, May 12, 19:51.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd0c31e0913ed: Fix a use after free error

Summary

D18073 mistakenly introduced a use after free bug by avoiding a copy that was made on purpose and holding a reference to an iterator pointed item that is removed in the next line, causing the reference to be dangling.

Test Plan

./contrib/teamcity/build-configurations.py build-asan

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, May 12, 19:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 12, 19:51

Fabien requested review of this revision.Mon, May 12, 19:51

PiRK accepted this revision.Mon, May 12, 19:53

This revision is now accepted and ready to land.Mon, May 12, 19:53

@bot build-asan

teamcity awarded a token.Mon, May 12, 20:04

Harbormaster completed remote builds in B33280: Diff 53956.Mon, May 12, 20:08

Closed by commit rABCd0c31e0913ed: Fix a use after free error (authored by Fabien). · Explain WhyMon, May 12, 20:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd0c31e0913ed: Fix a use after free error.

Revision Contents
Changeset List

Path

Size

src/

kernel/

disconnected_transactions.cpp

3 lines

Diff 53957

View Options

src/kernel/disconnected_transactions.cpp

Fix a use after free errorClosedPublicActions