Page MenuHomePhabricator

[cashtab] Prevent wheel event for agora price setting input.
Needs RevisionPublic

Authored by alitayin on Tue, May 13, 06:46.

Details

Reviewers
bytesofman
emack
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Price setting should be consistent with the send input box and disable the wheel event, because this
can cause users to scroll down and quickly click list etoken after entering a price, by which time the price has
already changed. Similar cases have occurred several times recently. Since preventing the event doesn't work
here, a safer method of blur (losing focus) was used.

Test Plan

Local demo testing

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alita0513
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33286
Build 66054: Build Diffcashtab-tests
Build 66053: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Tue, May 13, 06:46

this exists in a few spots in Cashtab, and is correctly fixed on the latest input -- the one on the Receive screen

Please use that same approach, i.e. keep onWheel here, but also any number input should be type="number" (set where the component is used, not in Inputs.tsx, if it is indeed a number input) -- in this way mobile users get the number pad instead of the keyboard

This revision now requires changes to proceed.Tue, May 13, 12:59