Page MenuHomePhabricator

doc: Improve assumeutxo guide and add more docs/comments
ClosedPublic

Authored by PiRK on May 22 2025, 13:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC27f226810d4d: doc: Improve assumeutxo guide and add more docs/comments
Summary

This new doc will be available on the bitcoinabc.org/doc/assumeutxo.html URL after the next deployment of the website, and can be given to users.
When can add a link to snapshot files when the hosting is sorted out (see TODO note left in the document).

I added a section to document the current Chronik incompatibility, similar to what is in the release notes.

Also fixes some outdated information in the remaining design doc.

https://github.com/bitcoin/bitcoin/pull/29553/commits/e868a6e070a91c00555e72181f9b14bbf0373fdc

Add -rpcclienttimeout=0 to loadtxoutset examples

https://github.com/bitcoin/bitcoin/pull/30808/commits/c5eaae3b89c67c664c24a53908bea608785e481d

fix assumeutxo design doc link

This concludes backport of core#29553, core#30808 and core#30819
Depends D18125

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.May 22 2025, 13:56
src/rpc/blockchain.cpp
2719 ↗(On Diff #54125)
Fabien requested changes to this revision.May 23 2025, 08:01
Fabien added a subscriber: Fabien.

A few nits but generally looks good

doc/assumeutxo.md
47 ↗(On Diff #54125)

Macro wildnewlineappeared:

81 ↗(On Diff #54125)
src/rpc/blockchain.cpp
2716–2717 ↗(On Diff #54125)
This revision now requires changes to proceed.May 23 2025, 08:01
src/rpc/blockchain.cpp
2716–2717 ↗(On Diff #54125)

that is releavant to the loadtxoutset RPC (it is already documented in its help message)

This revision is now accepted and ready to land.May 23 2025, 11:51