Differential D18180

[chronik] Electrum: flush the send buffer in tests
ClosedPublic
Actions

Authored by Fabien on Jun 2 2025, 07:50.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd29b40a59970: [chronik] Electrum: flush the send buffer in tests

Summary

It's possible that sock.send() did not send all the data causing a deadlock, but sock.sendall() will ensure that it's completed.

Test Plan

./test/functional/test_runner.py chronik_electrum_*

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 2 2025, 07:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2025, 07:50

Fabien requested review of this revision.Jun 2 2025, 07:50

Harbormaster completed remote builds in B33490: Diff 54270.Jun 2 2025, 07:59

PiRK accepted this revision.Jun 2 2025, 08:33

This revision is now accepted and ready to land.Jun 2 2025, 08:33

Closed by commit rABCd29b40a59970: [chronik] Electrum: flush the send buffer in tests (authored by Fabien). · Explain WhyJun 2 2025, 08:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd29b40a59970: [chronik] Electrum: flush the send buffer in tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

jsonrpctools.py

2 lines

Diff 54272

View Options

test/functional/test_framework/jsonrpctools.py

[chronik] Electrum: flush the send buffer in testsClosedPublicActions