Paths

Table of Contentst

Differential D18202

[e.cash] Use UpperCamelCase for components
ClosedPublic
Actions

Authored by bytesofman on Jun 4 2025, 15:19.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC847730dc4340: [e.cash] Use UpperCamelCase for components

Summary

Follow usual JS/TS convention of using UpperCamelCase for components and classes, camelCase for utils.

Test Plan

npm run dev, npm run build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pascal-case-components

Lint

Lint Errors

Severity	Location	Code	Message
Error	web/e.cash_v2/app/components/ContentContainer.tsx:	PRETTIER	Linter error
Error	web/e.cash_v2/app/components/GridPattern.tsx:	PRETTIER	Linter error
Error	web/e.cash_v2/app/components/NavBar.tsx:	PRETTIER	Linter error
Error	web/e.cash_v2/app/components/TrustedBy.tsx:	PRETTIER	Linter error
Error	web/e.cash_v2/app/layout.tsx:	PRETTIER	Linter error
Error	web/e.cash_v2/app/page.tsx:	PRETTIER	Linter error

Unit

No Test Coverage

Build Status

Buildable 33531
Build 66541: Build Diff
Build 66540: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 4 2025, 15:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2025, 15:19

Harbormaster completed remote builds in B33531: Diff 54339.Jun 4 2025, 15:19

lint

Harbormaster completed remote builds in B33532: Diff 54340.Jun 4 2025, 15:20

bytesofman published this revision for review.Jun 4 2025, 15:24

johnkuney accepted this revision.Jun 4 2025, 15:40

This revision is now accepted and ready to land.Jun 4 2025, 15:40

Closed by commit rABC847730dc4340: [e.cash] Use UpperCamelCase for components (authored by bytesofman). · Explain WhyJun 4 2025, 16:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC847730dc4340: [e.cash] Use UpperCamelCase for components.

Revision Contents
Changeset List

Path

Size

web/

e.cash_v2/

app/

components/

	ContentContainer.tsx
	contentContainer.tsx

15 lines

	GridPattern.tsx
	gridPattern.tsx

20 lines

	NavBar.tsx
	navbar.tsx

23 lines

	TrustedBy.tsx
	trustedBy.tsx

8 lines

contentContainer.tsx

gridPattern.tsx

2 lines

36 lines

Diff 54339

web/e.cash_v2/app/components/ContentContainer.tsx

Loading...

web/e.cash_v2/app/components/GridPattern.tsx

Loading...

web/e.cash_v2/app/components/NavBar.tsx

Loading...

web/e.cash_v2/app/components/TrustedBy.tsx

Loading...

web/e.cash_v2/app/components/contentContainer.tsx

Loading...

web/e.cash_v2/app/components/gridPattern.tsx

Loading...

web/e.cash_v2/app/components/navbar.tsx

Loading...

web/e.cash_v2/app/components/trustedBy.tsx

Loading...

web/e.cash_v2/app/layout.tsx

Loading...

web/e.cash_v2/app/page.tsx

Loading...