one of the things that comes up from implementing typescript

getLastFocusedWindow() may return undefined, which was previously unhandled. In practice ... never seen it happen.

so the || 0 is handling an undefined case.

Here is what we are actually getting (when I perform an extension interaction)

console.log(lastFocused)
{
    "alwaysOnTop": false,
    "focused": true,
    "height": 972,
    "id": 1111000106,
    "incognito": false,
    "left": 1920,
    "state": "maximized",
    "top": 32,
    "type": "normal",
    "width": 1920
}

so, top is 32 and left works out to 3390

the result is cashtab extension opens on the right side of the screen, full height of the window, with width NOTIFICATION_WIDTH

We do not want 0 ever, it's just to make sure we get a valid number if for whatever reason getLastFocusedWindow() returns undefined. So in this case, we just get the window in the top left, instead of (maybe) a crash.

In general -- the extension stuff needs tests. But typescript at least catches this kind of thing.

...mb right:0 or some other way of locating the pop-up is better than the calculated left ... but unrelated to this diff. I remember fighting with this when I put it together, but it was years ago. prob a better way to do all of the extension stuff now.

I think it's ok -- I'm seeing the same behavior as before the change when I build and use the extension

also TIL in JS