Page MenuHomePhabricator
Differential D18232

[chronik] Electrum: Implement blockchain.transaction.subscribe endpoint
ClosedPublic
Actions

Authored by Fabien on Jun 10 2025, 13:35.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa52a5004932b: [chronik] Electrum: Implement blockchain.transaction.subscribe endpoint
Summary

And the associated unsubscribe endpoint:
https://electrum-cash-protocol.readthedocs.io/en/latest/protocol-methods.html#blockchain-transaction-subscribe

Test Plan
./test/functional/test_runner.py chronik_electrum_blockchain

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 10 2025, 13:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2025, 13:35
Fabien requested review of this revision.Jun 10 2025, 13:35
Harbormaster completed remote builds in B33590: Diff 54427.Jun 10 2025, 13:55
PiRK added a subscriber: PiRK.Jun 10 2025, 16:25
PiRK added inline comments.
chronik/chronik-http/src/electrum.rs
1275–1277 ↗(On Diff #54427)

weird layout

1286–1292 ↗(On Diff #54427)

The spec mentions that the value could be null if the tx is unknown (0 is for mempool txs) https://electrum-cash-protocol.readthedocs.io/en/latest/protocol-methods.html#blockchain.transaction.get_height

PiRK accepted this revision.Jun 10 2025, 16:40
PiRK added inline comments.
chronik/chronik-http/src/electrum.rs
1286–1292 ↗(On Diff #54427)

nvm, the test shows that the behavior is as expected (height can be None which translates to null)

This revision is now accepted and ready to land.Jun 10 2025, 16:40
Fabien added inline comments.Jun 10 2025, 18:15
chronik/chronik-http/src/electrum.rs
1286–1292 ↗(On Diff #54427)

ok() returns the option wrapped value or None, so height can be None

Closed by commit rABCa52a5004932b: [chronik] Electrum: Implement blockchain.transaction.subscribe endpoint (authored by Fabien). · Explain WhyJun 10 2025, 18:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa52a5004932b: [chronik] Electrum: Implement blockchain.transaction.subscribe endpoint.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
119 lines
test/
functional/
128 lines

Diff 54435

View Options

chronik/chronik-http/src/electrum.rs

Loading...
View Options

test/functional/chronik_electrum_blockchain.py

Loading...