Page MenuHomePhabricator

[chronik] Unbreak the build when the old variables are used
ClosedPublic

Authored by Fabien on Jun 11 2025, 12:56.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC6dfd68ed4354: [chronik] Unbreak the build when the old variables are used
Summary

For builds that still use the BUILD_BITCOIN_CHRONIK build option, the new BUILD_CHRONIK value is set after the config directory is included, which causes the ENABLE_CHRONIK preprocessor to be off in the generated bitcoin-config.h. This diff defines the build value first so the header file is correct.
This doesn't prevent from building but the node bindings are not build without this change, and starting a node with -chronik=1 fails (unknown option). Note that this works just fine if the new build option is used.

Test Plan

Build with the old chronik build flag and run the functional tests.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 11 2025, 12:56
This revision is now accepted and ready to land.Jun 11 2025, 12:57
This revision was landed with ongoing or failed builds.Jun 11 2025, 12:58
This revision was automatically updated to reflect the committed changes.