Page MenuHomePhabricator

Skip creating parent directories when accessing a file in read-only mode from filesystem
ClosedPublic

Authored by Fabien on Jun 23 2025, 12:49.

Details

Summary

When reading a file on disk, we expect to fail if the file is not found. We can safely skip creating the parent directories in this case since we won't create the file anyway (this requires a write access).
This create_directories call involves 2 syscalls (on Linux) per call and is about 30% of the time spent in the FlatFile::Open() method. This diff is an easy optimization that can boost the access requiring lots of reads, like the listunspent RPC or the various chronik history endpoints.

Test Plan

With Chronik:

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable