Differential D18319

[electrum] remove more dynamic fee related dead code
ClosedPublic
Actions

Authored by PiRK on Jul 3 2025, 14:26.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3295e196b74a: [electrum] remove more dynamic fee related dead code

Summary

Most of it was deleted in https://github.com/Bitcoin-ABC/ElectrumABC/pull/45
This was left over.

Removing this has the side benefit of getting rid of a translation hack in util.py

Test Plan

Run the application, play with the fee slider, go to preferences and select custom fee rate and type something.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 3 2025, 14:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2025, 14:26

PiRK requested review of this revision.Jul 3 2025, 14:26

PiRK mentioned this in D18316: [electrum] move-only: move amount formatting functions from util to amount.py.Jul 3 2025, 14:30

PiRK edited the summary of this revision. (Show Details)Jul 3 2025, 14:31

Harbormaster completed remote builds in B33746: Diff 54670.Jul 3 2025, 14:32

Fabien accepted this revision.Jul 3 2025, 15:44

This revision is now accepted and ready to land.Jul 3 2025, 15:44

Closed by commit rABC3295e196b74a: [electrum] remove more dynamic fee related dead code (authored by PiRK). · Explain WhyJul 4 2025, 09:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3295e196b74a: [electrum] remove more dynamic fee related dead code.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

util.py

18 lines

electrumabc_gui/

qt/

fee_slider.py

16 lines

main_window.py

9 lines

Diff 54688

View Options

electrum/electrumabc/util.py

View Options

electrum/electrumabc_gui/qt/fee_slider.py

View Options

electrum/electrumabc_gui/qt/main_window.py

[electrum] remove more dynamic fee related dead codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54688

electrum/electrumabc/util.py

electrum/electrumabc_gui/qt/fee_slider.py

electrum/electrumabc_gui/qt/main_window.py

[electrum] remove more dynamic fee related dead code
ClosedPublic
Actions

Revision Contents
Changeset List