Paths

Table of Contentst

Differential D18330

[electrum] fix fee unit in Preferences > Fee > Custom Fee Rate
ClosedPublic
Actions

Authored by PiRK on Sat, Jul 5, 12:38.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2649c671c6a0: [electrum] fix fee unit in Preferences > Fee > Custom Fee Rate

Summary

Setting the XECSatsByteEdit._base_unit attribute had no effect in updating the widget's displayed unit. There is a AmountEdit.set_base_unit method for this, use it.

Remove also the pointless instance attribute in XECAmountEdit

Test Plan

start Electrum ABC, go to the preferences menu, fee tab, and check that the correct unit is displayed in the line edit idget (previously it showed "XEC")

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sat, Jul 5, 12:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jul 5, 12:38

PiRK requested review of this revision.Sat, Jul 5, 12:38

Harbormaster completed remote builds in B33771: Diff 54703.Sat, Jul 5, 12:45

Fabien accepted this revision.Mon, Jul 7, 07:49

This revision is now accepted and ready to land.Mon, Jul 7, 07:49

Closed by commit rABC2649c671c6a0: [electrum] fix fee unit in Preferences > Fee > Custom Fee Rate (authored by PiRK). · Explain WhyMon, Jul 7, 09:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2649c671c6a0: [electrum] fix fee unit in Preferences > Fee > Custom Fee Rate.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

6 lines

Diff 54719

electrum/electrumabc_gui/qt/amountedit.py

Loading...