[electrum] fix the transaction dialog for Qt6
ClosedPublic
Actions

Authored by PiRK on Jul 9 2025, 09:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1a929605f51e: [electrum] fix the transaction dialog for Qt6

Summary

Fixes the following error with pyqt6:

File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_gui/qt/transaction_dialog.py", line 225, in __init__
    b.setShortcut(QKeySequence(Qt.ALT + Qt.Key_Q))
                               ~~~~~~~^~~~~~~~~~
TypeError: unsupported operand type(s) for +: 'Modifier' and 'Key'

Test Plan

With pyqt5 and pyqt6 (QT_API=pyqt6 ./electrum-abc):
In the tx history, right click on a tx and select Details in the menu. Check for no error and that the Alt+Q shortcut works

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 9 2025, 09:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2025, 09:18

PiRK requested review of this revision.Jul 9 2025, 09:18

I seearched for setShortcut and QKeySequence and found no other occurence of the + operator being used (except for the string constructor which still works, QKeySequence("Shift+Ctrl+P"))

Harbormaster completed remote builds in B33810: Diff 54760.Jul 9 2025, 09:26

Fabien accepted this revision.Jul 9 2025, 14:17

This revision is now accepted and ready to land.Jul 9 2025, 14:17

Closed by commit rABC1a929605f51e: [electrum] fix the transaction dialog for Qt6 (authored by PiRK). · Explain WhyJul 10 2025, 10:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1a929605f51e: [electrum] fix the transaction dialog for Qt6.