Page MenuHomePhabricator
Differential D18368

net: Give seednodes time before falling back to fixed seeds
ClosedPublic
Actions

Authored by PiRK on Jul 15 2025, 13:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7d0a42894a24: net: Give seednodes time before falling back to fixed seeds
Summary

Before, we'd remove a seednode from the list right after connecting
to it, leading to a race with loading the fixed seed and connecting
to them.

This is a backport of core#27577

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 15 2025, 13:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2025, 13:53
PiRK requested review of this revision.Jul 15 2025, 13:53
teamcity edited the summary of this revision. (Show Details)Jul 15 2025, 13:53
Harbormaster completed remote builds in B33882: Diff 54856.Jul 15 2025, 14:15
Fabien requested changes to this revision.Jul 15 2025, 14:22
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
1705 ↗(On Diff #54856)

Please fix the layout, the above empty line and comment makes it easy to miss the else, which is the actual behavior change

This revision now requires changes to proceed.Jul 15 2025, 14:22
PiRK updated this revision to Diff 54859.Jul 15 2025, 15:23

move the comment inside the else if scope and rephrase it accordingly. Remove blank line

Harbormaster completed remote builds in B33885: Diff 54859.Jul 15 2025, 15:36
Fabien accepted this revision.Jul 15 2025, 15:48
This revision is now accepted and ready to land.Jul 15 2025, 15:48
Closed by commit rABC7d0a42894a24: net: Give seednodes time before falling back to fixed seeds (authored by Martin Zumsande <mzumsande@gmail.com>, committed by PiRK). · Explain WhyJul 16 2025, 13:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7d0a42894a24: net: Give seednodes time before falling back to fixed seeds.

Revision Contents
Changeset List

PathSize
src/
16 lines
test/
functional/
4 lines

Diff 54880

View Options

src/net.cpp

Loading...
View Options

test/functional/feature_config_args.py

Loading...