Paths

Table of Contentst

Differential D18403

[ecash-lib, CI] Modify output type to include the OP_RETURN template
ClosedPublic
Actions

Authored by bytesofman on Jul 22 2025, 20:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC73c0c8709fe1: [ecash-lib, CI] Modify output type to include the OP_RETURN template

Summary

Modify CI so that cashtab-faucet tests run when ecash-lib changes. ecash-lib CI is broken because the latest version of ecash-lib throws a ts-error on the blank OP_RETURN type { sats: 0n }

Update type so this is tolerated, update CI to prevent recurrence.

Test Plan

npm test

cd apps/cashtab-faucet
npm run build
npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jul 22 2025, 20:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2025, 20:51

bytesofman edited the test plan for this revision. (Show Details)Jul 22 2025, 20:52

Harbormaster completed remote builds in B33952: Diff 54964.Jul 22 2025, 21:04

bytesofman published this revision for review.Jul 22 2025, 21:05

Fabien accepted this revision.Jul 22 2025, 21:52

This revision is now accepted and ready to land.Jul 22 2025, 21:52

Closed by commit rABC73c0c8709fe1: [ecash-lib, CI] Modify output type to include the OP_RETURN template (authored by bytesofman). · Explain WhyJul 22 2025, 21:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC73c0c8709fe1: [ecash-lib, CI] Modify output type to include the OP_RETURN template.

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.yml

1 line

modules/

ecash-lib/

README.md

1 line

package-lock.json

4 lines

package.json

2 lines

src/

payment/

output.ts

2 lines

Diff 54968

View Options

contrib/teamcity/build-configurations.yml

View Options

modules/ecash-lib/README.md

View Options

modules/ecash-lib/package-lock.json

View Options

modules/ecash-lib/package.json

View Options

modules/ecash-lib/src/payment/output.ts

[ecash-lib, CI] Modify output type to include the OP_RETURN templateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54968

contrib/teamcity/build-configurations.yml

modules/ecash-lib/README.md

modules/ecash-lib/package-lock.json

modules/ecash-lib/package.json

modules/ecash-lib/src/payment/output.ts

[ecash-lib, CI] Modify output type to include the OP_RETURN template
ClosedPublic
Actions

Revision Contents
Changeset List