Page MenuHomePhabricator
Differential D18466

[monorepo, cashtab] Upgrade nodeJS in CI and apps
ClosedPublic
Actions

Authored by bytesofman on Aug 9 2025, 03:33.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCc6b1cd060db9: [monorepo, cashtab] Upgrade nodeJS in CI and apps
Summary

I noticed Cashtab tests were passing with node 20 and failing with 22. The failure reasons include the (weird) issue of node 20 using 24:00:00 for midnight.

Anyway, we should always try to use the latest stable version.

So, bump node version in CI, update Cashtab tests to pass with node 22.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Aug 9 2025, 03:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2025, 03:33
Harbormaster completed remote builds in B34083: Diff 55148.Aug 9 2025, 03:53
bytesofman published this revision for review.Aug 9 2025, 03:57

not sure if there is more that has to be done to test the CI change here

PiRK accepted this revision.Aug 9 2025, 06:01
This revision is now accepted and ready to land.Aug 9 2025, 06:01
Closed by commit rABCc6b1cd060db9: [monorepo, cashtab] Upgrade nodeJS in CI and apps (authored by bytesofman). · Explain WhyAug 9 2025, 10:17
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCc6b1cd060db9: [monorepo, cashtab] Upgrade nodeJS in CI and apps.

Revision Contents
Changeset List

PathSize
apps/
cashtab-faucet/
2 lines
token-server/
2 lines
cashtab/
2 lines
4 lines
2 lines
src/
components/
App/
__tests__/
66 lines
Home/
Tx/
__tests__/
6 lines
contrib/
utils/
6 lines

Diff 55150

View Options

apps/cashtab-faucet/.nvmrc

Loading...
View Options

apps/token-server/.nvmrc

Loading...
View Options

cashtab/.nvmrc

Loading...
View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/App/__tests__/App.test.js

Loading...
View Options

cashtab/src/components/Home/Tx/__tests__/index.test.js

Loading...
View Options

contrib/utils/install-dependencies-bookworm.sh

Loading...