[ecash-herald] Escape chars in open ascii to prevent tg syntax errors
ClosedPublic
Actions

Authored by bytesofman on Sep 15 2025, 23:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC248db68879cf: [ecash-herald] Escape chars in open ascii to prevent tg syntax errors

Summary

Came up in logs from latest failure. Wherever herald is trying to print something as ASCII, we have to make sure we are not printing characters that Telegram will interpret as html. We have a function to do this but we need to implement it.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 15 2025, 23:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2025, 23:34

Harbormaster completed remote builds in B34458: Diff 55678.Sep 15 2025, 23:40

bytesofman published this revision for review.Sep 15 2025, 23:41

Fabien accepted this revision.Sep 16 2025, 07:50

This revision is now accepted and ready to land.Sep 16 2025, 07:50

Closed by commit rABC248db68879cf: [ecash-herald] Escape chars in open ascii to prevent tg syntax errors (authored by bytesofman). · Explain WhySep 16 2025, 12:14

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC248db68879cf: [ecash-herald] Escape chars in open ascii to prevent tg syntax errors.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.ts

7 lines

Diff 55694

View Options

apps/ecash-herald/src/parse.ts

[ecash-herald] Escape chars in open ascii to prevent tg syntax errorsClosedPublicActions