Page MenuHomePhabricator
Differential D18657

[Chronik] Use ffi `client_name` instead of hard-coded string
ClosedPublic
Actions

Authored by tobias_ruck on Sep 20 2025, 09:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC068d8a211259: [Chronik] Use ffi `client_name` instead of hard-coded string
Summary

Currently, "Bitcoin ABC" is hard-coded in electrum.rs.

However, it is better to get the client name from clientversion.cpp. This way, forks of Bitcoin ABC with a different name (*cough* doged *cough*) don't have to update this hard-coded string.

Test Plan

ninja && python ./test/functional/test_runner.py chronik_electrum_basic.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
chronik/
chronik-bridge/
src/
3 lines
chronik-cpp/
2 lines
4 lines
chronik-http/
src/
3 lines

Diff 55764

View Options

chronik/chronik-bridge/src/ffi.rs

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/chronik-http/src/electrum.rs

Loading...