test: check BlockStatus when InvalidateBlock is used
ClosedPublic
Actions

Authored by PiRK on Tue, Oct 14, 13:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC49edbad09b31: test: check BlockStatus when InvalidateBlock is used

Summary

when a block is invalidated using InvalidateBlock, check that:

it's status is BLOCK_FAILED_VALID
it's children's status is BLOCK_FAILED_CHILD and not BLOCK_FAILED_VALID
it's ancestors are valid

This is a partial backport of core#31835
https://github.com/bitcoin/bitcoin/pull/31835/commits/9e29653b424b324c753526fbbf9fdbc92e88244f

Note that this test is for a bug that was fixed independently in Bitcoin ABC in D5041

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, Oct 14, 13:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Oct 14, 13:36

PiRK requested review of this revision.Tue, Oct 14, 13:36

teamcity edited the summary of this revision. (Show Details)Tue, Oct 14, 13:36

Harbormaster completed remote builds in B34781: Diff 56173.Tue, Oct 14, 13:50

Fabien accepted this revision.Tue, Oct 14, 14:20

This revision is now accepted and ready to land.Tue, Oct 14, 14:20

Closed by commit rABC49edbad09b31: test: check BlockStatus when InvalidateBlock is used (authored by stratospher <44024636+stratospher@users.noreply.github.com>, committed by PiRK). · Explain WhyWed, Oct 15, 09:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC49edbad09b31: test: check BlockStatus when InvalidateBlock is used.

Revision Contents
Changeset List

Path

Size

src/

test/

blockchain_tests.cpp

36 lines

Diff 56180

View Options

src/test/blockchain_tests.cpp

test: check BlockStatus when InvalidateBlock is usedClosedPublicActions